Skip to content

Footnote scrollable, when > 10#2238

Merged
mariusheine merged 2 commits intomainfrom
footnote-scrollable
Mar 9, 2026
Merged

Footnote scrollable, when > 10#2238
mariusheine merged 2 commits intomainfrom
footnote-scrollable

Conversation

@TruongQuangSB
Copy link
Contributor

@TruongQuangSB TruongQuangSB commented Mar 6, 2026

No description provided.

@github-actions
Copy link

github-actions bot commented Mar 6, 2026 •
edited
Loading

Test Results

131 tests  ±0   131 ✅ ±0   32s ⏱️ +7s
 31 suites ±0     0 💤 ±0 
 31 files   ±0     0 ❌ ±0 

Results for commit 94f1831. ± Comparison against base commit 8518d2a.

This pull request removes 9 and adds 9 tests. Note that renamed tests count towards both. 
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[1] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@1dc3502b
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[2] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@59696551
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[3] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@15c4af7a
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[4] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@55d58825
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[5] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@29a98d9f
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[1] TestData [input=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@795faad, expected=multi/container-id/2025652936/element-id]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[2] TestData [input=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@69f3e556, expected=multi/456/1206258545/123]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[1] TestData [input=Pair [first=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@99c3cee, second=other], expected=multi/container-id/1482010861/element-id/other=other]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[2] TestData [input=Pair [first=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@60ab895f, second=xxx], expected=multi/456/1097632693/123/other=xxx]

org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[1] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@5e5af8e1
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[2] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@4228bf58
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[3] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@2938127d
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[4] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@ff23ae7
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[5] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@2b7962a2
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[1] TestData [input=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@210d3a42, expected=multi/container-id/213063852/element-id]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[2] TestData [input=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@6f4adaab, expected=multi/456/1978560393/123]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[1] TestData [input=Pair [first=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@75bf9e67, second=other], expected=multi/container-id/679137498/element-id/other=other]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[2] TestData [input=Pair [first=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@45c408a4, second=xxx], expected=multi/456/444700929/123/other=xxx]

♻️ This comment has been updated with latest results.

@mariusheine
Copy link
Contributor

mariusheine commented Mar 9, 2026

@TruongQuangSB The scrollbar in the footnote section is visible now all the time. And the footnote section can become quite high when there are many footnotes. I think this is not necessary anymore. The container can stay with the height of 10 lines in my opinion

@TruongQuangSB
Copy link
Contributor Author

TruongQuangSB commented Mar 9, 2026

@TruongQuangSB The scrollbar in the footnote section is visible now all the time. And the footnote section can become quite high when there are many footnotes. I think this is not necessary anymore. The container can stay with the height of 10 lines in my opinion

i have hided scrollbar by unnecessary. But the container height to modify is complex

@mariusheine mariusheine merged commit cbc87a9 into main Mar 9, 2026
14 checks passed
@mariusheine mariusheine deleted the footnote-scrollable branch March 9, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TruongQuangSB @mariusheine